On Tue, 11 Jun 2019 20:03:26 +0200 Matteo Croce <mcr...@redhat.com> wrote:
> Even if not running the testsuite, every build will leave > a stale tc_testkenv.* file in the system temp directory. > Conditionally create the temp file only if we're running the testsuite. > > Signed-off-by: Matteo Croce <mcr...@redhat.com> > --- > testsuite/Makefile | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/testsuite/Makefile b/testsuite/Makefile > index 7f247bbc..5353244b 100644 > --- a/testsuite/Makefile > +++ b/testsuite/Makefile > @@ -14,7 +14,9 @@ TESTS_DIR := $(dir $(TESTS)) > > IPVERS := $(filter-out iproute2/Makefile,$(wildcard iproute2/*)) > > -KENVFN := $(shell mktemp /tmp/tc_testkenv.XXXXXX) > +ifeq ($(MAKECMDGOALS),alltests) > + KENVFN := $(shell mktemp /tmp/tc_testkenv.XXXXXX) > +endif > ifneq (,$(wildcard /proc/config.gz)) > KCPATH := /proc/config.gz > else > @@ -94,3 +96,4 @@ endif > rm "$$TMP_ERR" "$$TMP_OUT"; \ > sudo dmesg > $(RESULTS_DIR)/$@.$$o.dmesg; \ > done > + @$(RM) $(KENVFN) My concern is that there are several targets in this one Makefile. Why not use -u which gives name but does not create the file?
