Re: [PATCH net-next 1/3] selftests: mlxsw: Add ethtool_lib.sh

[Florian Fainelli]

On 6/10/2019 6:56 AM, Ido Schimmel wrote:
> On Mon, Jun 10, 2019 at 03:35:38PM +0200, Andrew Lunn wrote:
>> On Mon, Jun 10, 2019 at 11:40:43AM +0300, Ido Schimmel wrote:
>>> From: Amit Cohen <am...@mellanox.com>
>>> +declare -A speed_values
>>> +
>>> +speed_values=(     [10baseT/Half]=0x001
>>> +           [10baseT/Full]=0x002
>>> +           [100baseT/Half]=0x004
>>> +           [100baseT/Full]=0x008
>>> +           [1000baseT/Half]=0x010
>>> +           [1000baseT/Full]=0x020
>>
>> Hi Ido, Amit
>>
>> 100BaseT1 and 1000BaseT1 were added recently.
> 
> Hi Andrew,
> 
> Didn't see them in the man page, so didn't include them. I now see your
> patches are in the queue. Will add these speeds in v2.

Could we extract the values from include/uapi/linux/ethtool.h, that way
we would not have to have to update the selftest speed_values() array here?
-- 
Florian