> -----Original Message-----
> From: David Miller <da...@davemloft.net>
> Sent: Thursday, May 30, 2019 10:42 PM
> To: Jubran, Samih <same...@amazon.com>
> Cc: netdev@vger.kernel.org; Kiyanovski, Arthur <akiy...@amazon.com>;
> Woodhouse, David <d...@amazon.co.uk>; Machulsky, Zorik
> <zo...@amazon.com>; Matushevsky, Alexander <ma...@amazon.com>;
> Bshara, Saeed <sae...@amazon.com>; Wilson, Matt <m...@amazon.com>;
> Liguori, Anthony <aligu...@amazon.com>; Bshara, Nafea
> <na...@amazon.com>; Tzalik, Guy <gtza...@amazon.com>; Belgazal,
> Netanel <neta...@amazon.com>; Saidi, Ali <alisa...@amazon.com>;
> Herrenschmidt, Benjamin <b...@amazon.com>
> Subject: Re: [PATCH V1 net-next 02/11] net: ena: ethtool: add extra
> properties retrieval via get_priv_flags
>
> From: <same...@amazon.com>
> Date: Wed, 29 May 2019 12:49:55 +0300
>
> > @@ -560,6 +564,14 @@ struct ena_admin_set_feature_mtu_desc {
> > u32 mtu;
> > };
> >
> > +struct ena_admin_get_extra_properties_strings_desc {
> > + u32 count;
> > +};
> > +
> > +struct ena_admin_get_extra_properties_flags_desc {
> > + u32 flags;
> > +};
>
> These single entry structures are a big overkill. If anything just do one
> which
> is like "ena_value_desc" and has that "u32 val;"
We think that it's better to leave it as it is, since it's more readable when
the types and fields have meaningful names, and it also leaves place for
extending it in the future.
