Hello Ioana, On Tue, 28 May 2019 20:38:12 +0300 Ioana Ciornei <ioana.cior...@nxp.com> wrote:
>The phylink_config structure will encapsulate a pointer to a struct >device and the operation type requested for this instance of PHYLINK. >This patch does not make any functional changes, it just transitions the >PHYLINK internals and all its users to the new API. > >A pointer to a phylink_config structure will be passed to >phylink_create() instead of the net_device directly. Also, the same >phylink_config pointer will be passed back to all phylink_mac_ops >callbacks instead of the net_device. Using this mechanism, a PHYLINK >user can get the original net_device using a structure such as >'to_net_dev(config->dev)' or directly the structure containing the >phylink_config using a container_of call. I see that you mixed both to_net_dev and container_of uses in mvpp2, is there a reason for that ? Other than that, for the mvpp2 part, Reviewed-by: Maxime Chevallier <maxime.chevall...@bootlin.com> Tested-by: Maxime Chevallier <maxime.chevall...@bootlin.com> Thanks, Maxime
