> Subject: Re: [PATCH 07/11] net: phylink: Add PHYLINK_DEV operation type > > > > On 5/27/2019 2:22 PM, Ioana Ciornei wrote: > > In the PHYLINK_DEV operation type, the PHYLINK infrastructure can work > > without an attached net_device. For printing usecases, instead, a > > struct device * should be passed to PHYLINK using the phylink_config > structure. > > > > Also, netif_carrier_* calls ar guarded by the presence of a valid > > net_device. When using the PHYLINK_DEV operation type, we cannot check > > link status using the netif_carrier_ok() API so instead, keep an > > internal state of the MAC and call mac_link_{down,up} only when the > > link changed. > > > > Signed-off-by: Ioana Ciornei <ioana.cior...@nxp.com> > > Signed-off-by: Vladimir Oltean <olte...@gmail.com> > > Should not this patch be re-ordered to be after patch #8? Other than that: >
Not necessarily. Even without patch #8 ("net: phylink: Add phylink_{printk,err,warn,info,dbg} macros") everything will function properly with the mention that in case of PHYLINK_DEV a NULL net_device will get printed. I chose to add the phylink_printk after this patch because now we have the whole picture. -- Ioana > Reviewed-by: Florian Fainelli <f.faine...@gmail.com> > -- > Florian