On 5/23/2019 2:45 AM, Jiri Pirko wrote:
> From: Jiri Pirko <j...@mellanox.com>
>
> When user is flashing device using devlink, he currenly does not see any
> information about what is going on, percentages, etc.
> Drivers, for example mlxsw and mlx5, have notion about the progress
> and what is happening. This patchset exposes this progress
> information to userspace.
>
> See this console recording which shows flashing FW on a Mellanox
> Spectrum device:
> https://asciinema.org/a/247926
It would be great to explain why you went that route instead of
implementing a MTD device (like what sfc) which would have presumably
allowed you to more or less the same thing using a standard device
driver model that is establish with flash devices.
>
> Jiri Pirko (7):
> mlxsw: Move firmware flash implementation to devlink
> mlx5: Move firmware flash implementation to devlink
> mlxfw: Propagate error messages through extack
> devlink: allow driver to update progress of flash update
> mlxfw: Introduce status_notify op and call it to notify about the
> status
> mlxsw: Implement flash update status notifications
> netdevsim: implement fake flash updating with notifications
>
> drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 -
> .../ethernet/mellanox/mlx5/core/en_ethtool.c | 35 ------
> drivers/net/ethernet/mellanox/mlx5/core/fw.c | 6 +-
> .../mellanox/mlx5/core/ipoib/ethtool.c | 9 --
> .../net/ethernet/mellanox/mlx5/core/main.c | 20 ++++
> .../ethernet/mellanox/mlx5/core/mlx5_core.h | 3 +-
> drivers/net/ethernet/mellanox/mlxfw/mlxfw.h | 11 +-
> .../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c | 57 ++++++++--
> drivers/net/ethernet/mellanox/mlxsw/core.c | 15 +++
> drivers/net/ethernet/mellanox/mlxsw/core.h | 3 +
> .../net/ethernet/mellanox/mlxsw/spectrum.c | 75 +++++++------
> drivers/net/netdevsim/dev.c | 35 ++++++
> include/net/devlink.h | 8 ++
> include/uapi/linux/devlink.h | 5 +
> net/core/devlink.c | 102 ++++++++++++++++++
> 15 files changed, 295 insertions(+), 91 deletions(-)
>
--
Florian
