Patch will be worked over and split. I'll need to investigate one more problem. Split patch will be resent when ready.
On Thu, 2019-05-23 at 09:11 -0700, David Miller wrote: > From: Andreas Steinmetz <a...@domdv.de> > Date: Thu, 23 May 2019 09:46:15 +0200 > > > MACsec causes oopses followed by a kernel panic when attached directly or > > indirectly to > a bridge. It causes erroneous > > checksum messages when attached to vxlan. When I did investigate I did find > > skb leaks, > apparent skb mis-handling and > > superfluous code. The attached patch fixes all MACsec misbehaviour I could > > find. As I > am no kernel developer somebody > > with sufficient kernel network knowledge should verify and correct the > > patch where > necessary. > > > > Signed-off-by: Andreas Steinmetz <a...@domdv.de> > > Subject lines should be of the form: > > [PATCH $DST_TREE] $subsystem_prefix: Description. > > Where $DST_TREE here would be "net" and $subsystem_prefix would be "macsec". > > > + /* FIXME: any better way to prevent calls to netdev_rx_csum_fault? */ > > + skb->csum_complete_sw = 1; > > Create a helper for this in linux/skbuff.h with very clear and clean comments > explaining what is going on.
