On 5/20/19 8:22 AM, Russell King wrote: > Add support for using GPIO interrupts with a fixed-link GPIO rather than > polling the GPIO every second and invoking the phylink resolution. This > avoids unnecessary calls to mac_config(). > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com> Just one comment, see below: [snip] > - if (pl->link_an_mode == MLO_AN_FIXED && !IS_ERR(pl->link_gpio)) > - del_timer_sync(&pl->link_poll); > + del_timer_sync(&pl->link_poll); Removing a timer that was only set-up if pl->link_an_mode == MLO_AN_FIXED probably does not hurt, but this breaks symmetry a bit here. -- Florian
