Pekka Pietikainen <[EMAIL PROTECTED]> writes: > On Wed, Jan 17, 2007 at 11:46:35AM -0500, Brandon Craig Rhodes wrote: >> Having further reviewed my code, I have changed my mind; the >> ieee80211_crypt_tkip routines are not designed to be responsible for >> creating enough headroom and tailroom. > > Even then, if ieee80211_tkip_encrypt() didn't produce debug output > for the not enough space-case, should that be added to catch other > potentially broken drivers?
I think your idea is an excellent one, and would have prevented my having to add a half-dozen printk()'s to the code myself to discover what was going on! I would be happy to submit such a patch myself, but am not sure what the local kernel conventions are regarding error messages - and the ieee80211_crypt_tkip.c functions seem wildly inconsistent with regard to debugging messages! In some circumstances, debug messages are always produced; in several others, net_ratelimit() is called to decided whether to print an error (but why in these cases and not others?); and in many cases, nothing is printed at all (is this because convention would dictate that the caller discover the error and print something out?). If I want to generate a patch that festoons the ieee80211 functions with informative error messages, what are the guidelines? -- Brandon Craig Rhodes [EMAIL PROTECTED] http://rhodesmill.org/brandon - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
