On Tue, May 07, 2019 at 10:35:59AM +0200, Miroslav Lichvar wrote: > On Mon, May 06, 2019 at 07:01:23AM -0700, Richard Cochran wrote: > > On Thu, Apr 25, 2019 at 09:40:06PM +0800, Hangbin Liu wrote: > > > Would you please help have a look at it and see which way we should use? > > > Drop SIOCSHWTSTAMP in container or add a filter on macvlan(maybe only in > > > container)? > > > > I vote for dropping SIOCSHWTSTAMP altogether. Why? Because the > > filter idea means that the ioctl will magically succeed or fail, based > > on the unknowable state of the container's host. > > That's a good point. I agree that SIOCSHWTSTAMP always failing would > be a less surprising behavior than failing only with some specific > configurations.
Thanks for the reply. As net-next is closed now. I will post the fix to net branch after merging finished. Cheers Hangbin
