Hi Matthew, Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master] [also build test ERROR on v5.1-rc7] [cannot apply to next-20190501] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox/net-Increase-the-size-of-skb_frag_t/20190502-125302 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot <l...@intel.com> All error/warnings (new ones prefixed by >>): drivers/hsi/clients/ssi_protocol.c: In function 'ssip_skb_to_msg': >> drivers/hsi/clients/ssi_protocol.c:197:19: error: implicit declaration of >> function 'skb_page_frag'; did you mean 'skb_free_frag'? >> [-Werror=implicit-function-declaration] sg_set_page(sg, skb_page_frag(frag), frag->size, ^~~~~~~~~~~~~ skb_free_frag >> drivers/hsi/clients/ssi_protocol.c:197:19: warning: passing argument 2 of >> 'sg_set_page' makes pointer from integer without a cast [-Wint-conversion] In file included from include/linux/dma-mapping.h:11:0, from include/linux/skbuff.h:35, from include/linux/if_ether.h:23, from drivers/hsi/clients/ssi_protocol.c:31: include/linux/scatterlist.h:116:20: note: expected 'struct page *' but argument is of type 'int' static inline void sg_set_page(struct scatterlist *sg, struct page *page, ^~~~~~~~~~~ cc1: some warnings being treated as errors vim +197 drivers/hsi/clients/ssi_protocol.c 182 183 static void ssip_skb_to_msg(struct sk_buff *skb, struct hsi_msg *msg) 184 { 185 skb_frag_t *frag; 186 struct scatterlist *sg; 187 int i; 188 189 BUG_ON(msg->sgt.nents != (unsigned int)(skb_shinfo(skb)->nr_frags + 1)); 190 191 sg = msg->sgt.sgl; 192 sg_set_buf(sg, skb->data, skb_headlen(skb)); 193 for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { 194 sg = sg_next(sg); 195 BUG_ON(!sg); 196 frag = &skb_shinfo(skb)->frags[i]; > 197 sg_set_page(sg, skb_page_frag(frag), frag->size, 198 frag->page_offset); 199 } 200 } 201 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
