> -----Original Message-----
> From: netdev-ow...@vger.kernel.org <netdev-ow...@vger.kernel.org> On
> Behalf Of Leon Romanovsky
> Sent: Monday, April 29, 2019 1:41 PM
> To: Saeed Mahameed <sae...@mellanox.com>
> Cc: Jason Gunthorpe <j...@mellanox.com>; netdev@vger.kernel.org; linux-
> r...@vger.kernel.org; Maor Gottlieb <ma...@mellanox.com>; Mark Bloch
> <ma...@mellanox.com>
> Subject: Re: [PATCH V2 mlx5-next 09/11] net/mlx5: Eswitch, enable RoCE
> loopback traffic
>
> On Mon, Apr 29, 2019 at 06:14:16PM +0000, Saeed Mahameed wrote:
> > From: Maor Gottlieb <ma...@mellanox.com>
> >
> > When in switchdev mode, we would like to treat loopback RoCE traffic
> > (on eswitch manager) as RDMA and not as regular Ethernet traffic In
> > order to enable it we add flow steering rule that forward RoCE
> > loopback traffic to the HW RoCE filter (by adding allow rule).
> > In addition we add RoCE address in GID index 0, which will be set in
> > the RoCE loopback packet.
> >
I likely don't understand nor I reviewed the patches.
Part that I don't understand is GID index 0 for RoCE.
RoCE traffic runs over all the GID entries and for all practical purposes from
non_zero index.
How will it work?
It is better if you explain it in the commit log, why its done this way, 'what'
part is already present the patch.
> > Signed-off-by: Maor Gottlieb <ma...@mellanox.com>
> > Reviewed-by: Mark Bloch <ma...@mellanox.com>
> > Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
> > ---
> > .../net/ethernet/mellanox/mlx5/core/Makefile | 2 +-
> > .../mellanox/mlx5/core/eswitch_offloads.c | 4 +
> > .../net/ethernet/mellanox/mlx5/core/rdma.c | 182 ++++++++++++++++++
> > .../net/ethernet/mellanox/mlx5/core/rdma.h | 20 ++
> > include/linux/mlx5/driver.h | 7 +
> > 5 files changed, 214 insertions(+), 1 deletion(-) create mode 100644
> > drivers/net/ethernet/mellanox/mlx5/core/rdma.c
> > create mode 100644 drivers/net/ethernet/mellanox/mlx5/core/rdma.h
> >
>
> Thanks,
> Acked-by: Leon Romanovsky <leo...@mellanox.com>
