This allows drivers to query the VLAN setting imposed by the bridge
driver directly from DSA, instead of keeping their own state based on
the .port_vlan_filtering callback.

Signed-off-by: Vladimir Oltean <olte...@gmail.com>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
---
 include/net/dsa.h |  1 +
 net/dsa/port.c    | 12 ++++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/include/net/dsa.h b/include/net/dsa.h
index b550f7bb5314..79a87913126c 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -161,6 +161,7 @@ struct dsa_port {
        const char              *mac;
        struct device_node      *dn;
        unsigned int            ageing_time;
+       bool                    vlan_filtering;
        u8                      stp_state;
        struct net_device       *bridge_dev;
        struct devlink_port     devlink_port;
diff --git a/net/dsa/port.c b/net/dsa/port.c
index ea848596afe3..0caf7f9bfb57 100644
--- a/net/dsa/port.c
+++ b/net/dsa/port.c
@@ -158,15 +158,19 @@ int dsa_port_vlan_filtering(struct dsa_port *dp, bool 
vlan_filtering,
                            struct switchdev_trans *trans)
 {
        struct dsa_switch *ds = dp->ds;
+       int err;
 
        /* bridge skips -EOPNOTSUPP, so skip the prepare phase */
        if (switchdev_trans_ph_prepare(trans))
                return 0;
 
-       if (ds->ops->port_vlan_filtering)
-               return ds->ops->port_vlan_filtering(ds, dp->index,
-                                                   vlan_filtering);
-
+       if (ds->ops->port_vlan_filtering) {
+               err = ds->ops->port_vlan_filtering(ds, dp->index,
+                                                  vlan_filtering);
+               if (err)
+                       return err;
+               dp->vlan_filtering = vlan_filtering;
+       }
        return 0;
 }
 
-- 
2.17.1

Reply via email to