Hi Neil,

you once reported the original issue resulting in this workaround.
This workaround shouldn't be needed any longer, but I have no affected HW
to test on. Do you have the option to apply the patch below to latest
net-next and test link speed after resume from suspend?
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
That would be much appreciated.

Heiner

----------------------------------------------------------------

After 8c90b795e90f ("net: phy: improve genphy_soft_reset") this
workaround shouldn't be needed any longer. However I don't have
affected hardware so I can't test it.

This was the bug report leading to the workaround:
https://bugzilla.kernel.org/show_bug.cgi?id=201081

Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com>
---
 drivers/net/ethernet/realtek/r8169.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/net/ethernet/realtek/r8169.c 
b/drivers/net/ethernet/realtek/r8169.c
index 383242df0..d4ec08e37 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -4083,14 +4083,6 @@ static void rtl8169_init_phy(struct net_device *dev, 
struct rtl8169_private *tp)
        phy_speed_up(tp->phydev);
 
        genphy_soft_reset(tp->phydev);
-
-       /* It was reported that several chips end up with 10MBit/Half on a
-        * 1GBit link after resuming from S3. For whatever reason the PHY on
-        * these chips doesn't properly start a renegotiation when soft-reset.
-        * Explicitly requesting a renegotiation fixes this.
-        */
-       if (tp->phydev->autoneg == AUTONEG_ENABLE)
-               phy_restart_aneg(tp->phydev);
 }
 
 static void rtl_rar_set(struct rtl8169_private *tp, u8 *addr)
-- 
2.21.0

Reply via email to