On Tue, Apr 23, 2019 at 5:07 AM Lars Persson <li...@bofh.nu> wrote: > > On Tue, Apr 23, 2019 at 12:29 AM Peter Oskolkov <p...@google.com> wrote: > > > > [ Upstream commit c23f35d19db3b36ffb9e04b08f1d91565d15f84f ] > > > > This is a refactoring patch: without changing runtime behavior, > > it moves rbtree-related code from IPv4-specific files/functions > > into .h/.c defrag files shared with IPv6 defragmentation code. > > > > Signed-off-by: Peter Oskolkov <p...@google.com> > > Cc: Eric Dumazet <eduma...@google.com> > > Cc: Florian Westphal <f...@strlen.de> > > Cc: Tom Herbert <t...@herbertland.com> > > Signed-off-by: David S. Miller <da...@davemloft.net> > > --- > > include/net/inet_frag.h | 16 ++- > > net/ipv4/inet_fragment.c | 293 +++++++++++++++++++++++++++++++++++++++ > > net/ipv4/ip_fragment.c | 290 ++++---------------------------------- > > 3 files changed, 335 insertions(+), 264 deletions(-) > > > Hi > > We get a compile error with gcc 8.2 after applying this patch: > net/ipv4/ip_fragment.c: In function 'ip_frag_queue': > net/ipv4/ip_fragment.c:390:1: error: label 'discard_qp' defined but > not used [-Werror=unused-label] > discard_qp:
Thanks for the report: I'll send a v2.
