On 4/17/2019 7:31 PM, Andrew Lunn wrote:
> Make the CONFIG symbols tristate and add help text.
>
> The broadcom and Microchip KSZ tag drivers support two different
> tagging protocols in one driver. Add a configuration option for the
> drivers, and then options to select the protocol.
>
> Create a submenu for the tagging drivers.
>
> Signed-off-by: Andrew Lunn <and...@lunn.ch>
> ---
[snip]
>
> -# tagging formats
> +config NET_DSA_TAG_BRCM_COMMON
> + tristate "Tag driver for Broadcom switch"
> + help
> + Say Y or M if you want to enable support for tagging frames
> + for the Broadcom switches.
The indentation between the tristate and help lines seems to be off a
little bit with spaces vs. tabs. This particular Kconfig symbol should
probably be hidden and selected by NET_DSA_TAG_BRCM and
NET_DSA_TAG_BRCM_PREPEND.
> +
> config NET_DSA_TAG_BRCM
> - bool
> + bool "Tag driver for Broadcom switch using in frame headers"
Plural: switches
> + depends on NET_DSA_TAG_BRCM_COMMON
> + help
> + Say Y if you want to enable support for tagging frames for the
> + Broadcom switches which place the tag after the MAC addresses.
After the MAC source address.
> +
>
> config NET_DSA_TAG_BRCM_PREPEND
> - bool
> + bool "Tag driver for Broadcom switches using prepended headers"
> + depends on NET_DSA_TAG_BRCM_COMMON
> + help
> + Say Y if you want to enable support for tagging frames for the
> + Broadcom switches which preprended headers.
Which places the tag before the Ethernet header (prepended).
--
Florian
