On 4/14/19 11:41 PM, Jiri Pirko wrote: > Mon, Apr 15, 2019 at 04:24:24AM CEST, dsah...@gmail.com wrote: >> On 4/13/19 10:20 AM, Jiri Pirko wrote: >>> From: Jiri Pirko <j...@mellanox.com> >>> >>> Currently there is one devlink instance created per network namespace. >>> That is quite odd considering the fact that devlink instance should >>> represent an ASIC. The following patches are going to move the devlink >>> instance even more down to a bus device, but until then, have one >>> devlink instance per netdevsim instance. Struct nsim_devlink is >>> introduced to hold fib setting. >>> >>> Signed-off-by: Jiri Pirko <j...@mellanox.com> >>> --- >>> drivers/net/netdevsim/devlink.c | 179 +++++++++++------------------- >>> drivers/net/netdevsim/fib.c | 103 +++++++---------- >>> drivers/net/netdevsim/netdev.c | 27 ++--- >>> drivers/net/netdevsim/netdevsim.h | 18 +-- >>> 4 files changed, 125 insertions(+), 202 deletions(-) >> >> you are making a lot of changes to how fib events are handled and not >> explaining what you are doing. > > They are handled in the exact same way. This is just about devlink > instance. Will add that to description. >
Data is currently stored as a net_generic. You are changing that. The changelog should state that.
