On 13.04.2019 19:07, Andrew Lunn wrote: > On Sat, Apr 13, 2019 at 06:51:16PM +0200, Heiner Kallweit wrote: >> The definition of array settings[] is quite lengthy meanwhile. Add a >> macro to shrink the definition. >> >> When doing this I saw that the new 200Gbps modes aren't supported >> in phylib yet. So add this. I think we need to document somewhere >> which places in phylib need to be touched if a new speed / mode is >> added. > > Yes, maybe something like > > BUILD_BUG_ON(__ETHTOOL_LINK_MODE_MASK_NBITS != 67); > > in drivers/net/phy/phy-core.c with a comment explaining what should be > done? > Yes, this sounds reasonable. We could use BUILD_BUG_ON_MSG to print this comment.
> Andrew > Heiner
