Hi Tom,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    
https://github.com/0day-ci/linux/commits/Tom-Herbert/exthdrs-Create-exthdrs_options-c/20190412-024542
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'


sparse warnings: (new ones prefixed by >>)

   net/ipv6/exthdrs_options.c:205:30: sparse: symbol 'ipv6_tlv_param_table' 
redeclared with different type (originally declared at include/net/ipv6.h:418) 
- different address spaces
>> net/ipv6/exthdrs_options.c:209:30: sparse: incorrect type in argument 1 
>> (different address spaces) @@    expected struct tlv_param_table 
>> *tlv_param_table @@    got struct tlv_param_struct tlv_param_table 
>> *tlv_param_table @@
   net/ipv6/exthdrs_options.c:209:30:    expected struct tlv_param_table 
*tlv_param_table
   net/ipv6/exthdrs_options.c:209:30:    got struct tlv_param_table [noderef] 
<asn:4>*<noident>
   net/ipv6/exthdrs_options.c:216:23: sparse: incorrect type in argument 1 
(different address spaces) @@    expected struct tlv_param_table 
*tlv_param_table @@    got struct tlv_param_struct tlv_param_table 
*tlv_param_table @@
   net/ipv6/exthdrs_options.c:216:23:    expected struct tlv_param_table 
*tlv_param_table
   net/ipv6/exthdrs_options.c:216:23:    got struct tlv_param_table [noderef] 
<asn:4>*<noident>

vim +209 net/ipv6/exthdrs_options.c

   204  
 > 205  struct tlv_param_table __rcu ipv6_tlv_param_table;
   206  
   207  static int __init ipv6_exthdrs_init(void)
   208  {
 > 209          return exthdrs_init(&ipv6_tlv_param_table, tlv_init_params,
   210                              ARRAY_SIZE(tlv_init_params));
   211  }
   212  module_init(ipv6_exthdrs_init);
   213  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Reply via email to