tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
head:   44f5e0480752b356f577aef90a5813299c3c60b1
commit: 35b71a34ada62c9573847a324bf06a133fe11b11 [28/30] net/tls: don't leak 
partially sent record in device mode
config: i386-randconfig-x008-201914 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        git checkout 35b71a34ada62c9573847a324bf06a133fe11b11
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net//tls/tls_main.c: In function 'tls_sk_proto_close':
>> net//tls/tls_main.c:290:29: error: 'TLS_HW' undeclared (first use in this 
>> function); did you mean 'TLS_SW'?
     } else if (ctx->tx_conf == TLS_HW) {
                                ^~~~~~
                                TLS_SW
   net//tls/tls_main.c:290:29: note: each undeclared identifier is reported 
only once for each function it appears in

vim +290 net//tls/tls_main.c

   263  
   264  static void tls_sk_proto_close(struct sock *sk, long timeout)
   265  {
   266          struct tls_context *ctx = tls_get_ctx(sk);
   267          long timeo = sock_sndtimeo(sk, 0);
   268          void (*sk_proto_close)(struct sock *sk, long timeout);
   269          bool free_ctx = false;
   270  
   271          lock_sock(sk);
   272          sk_proto_close = ctx->sk_proto_close;
   273  
   274          if (ctx->tx_conf == TLS_HW_RECORD && ctx->rx_conf == 
TLS_HW_RECORD)
   275                  goto skip_tx_cleanup;
   276  
   277          if (ctx->tx_conf == TLS_BASE && ctx->rx_conf == TLS_BASE) {
   278                  free_ctx = true;
   279                  goto skip_tx_cleanup;
   280          }
   281  
   282          if (!tls_complete_pending_work(sk, ctx, 0, &timeo))
   283                  tls_handle_open_record(sk, 0);
   284  
   285          /* We need these for tls_sw_fallback handling of other packets 
*/
   286          if (ctx->tx_conf == TLS_SW) {
   287                  kfree(ctx->tx.rec_seq);
   288                  kfree(ctx->tx.iv);
   289                  tls_sw_free_resources_tx(sk);
 > 290          } else if (ctx->tx_conf == TLS_HW) {
   291                  tls_device_free_resources_tx(sk);
   292          }
   293  
   294          if (ctx->rx_conf == TLS_SW) {
   295                  kfree(ctx->rx.rec_seq);
   296                  kfree(ctx->rx.iv);
   297                  tls_sw_free_resources_rx(sk);
   298          }
   299  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to