From: Lucas Bates <luc...@mojatatu.com> Date: Mon, 8 Apr 2019 18:24:08 -0400
> On Sun, Apr 7, 2019 at 10:32 PM David Miller <da...@davemloft.net> wrote: >> > I'm not sure to understand the goal of this series: >> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=45b3a3762721 >> > >> > But after it, tc selftests are not intuitive anymore. When naively running >> > them >> > (./tdy.py), all fw filter tests fail. It's hard to understand that the >> > problem >> > is that they require the 'nsPlugin' plugin to be enabled (by adding a >> > symlink >> > *and* providing the '-n' option to tdc.py). >> > >> > Brenda, why putting the netns code into a plugin that is disabled by >> > default, >> > knowing that this code is mandatory to run the test? >> >> Brenda, please respond. > > This would be a documentation issue - the usage of nsPlugin is not > covered in the README. I'll submit a patch by end of the day tomorrow > to address it. > > The namespace code isn't mandatory, strictly speaking. It's not > required at all when running the action tests, only with the filter > tests as those need a specific device to be attached to. > > The actual problem is that the nsPlugin creates a veth pair using the > names found in the config file (DEV0/DEV1) - but if you aren't using > the plugin, then a port won't be created. The intention is that you'd > create a port manually before starting the tests. That's poor behavior. If I just want to run all the tests, I should be able to just execute the script with no special arguments. This setup sucks.
