On 04/08/2019 09:35 AM, Paolo Abeni wrote: > This revert commit 46b1c18f9deb ("net: sched: put back q.qlen > into a single location"). > After the previous patch nobody accesses directly qlen for a child > qdisc when such qdisc does per CPU stats accounting. > In the control path nobody uses directly qlen since commit > 677f1bc207c ("net: sched: introduce and use qdisc tree flush/purge > helpers"), so we can remove the contented atomic ops from the > datapath. > Have you tested HTB with a pfifo_fast on a throttled class ? I do not see any changes in HTB in your patch series, so it is not clear why your patch series is not adding back the issue.
- [PATCH net-next 0/5] net: sched: move back qlen to per C... Paolo Abeni
- [PATCH net-next 1/5] net: caif: avoid using qdisc_q... Paolo Abeni
- [PATCH net-next 2/5] net: sched: prefer qdisc_is_em... Paolo Abeni
- [PATCH net-next 3/5] net: sched: always do stats ac... Paolo Abeni
- Re: [PATCH net-next 3/5] net: sched: always do ... kbuild test robot
- Re: [PATCH net-next 3/5] net: sched: always... Paolo Abeni
- Re: [PATCH net-next 3/5] net: sched: always do ... kbuild test robot
- [PATCH net-next 5/5] Revert: "net: sched: put ... Paolo Abeni
- Re: [PATCH net-next 5/5] Revert: "net: sch... Eric Dumazet
- Re: [PATCH net-next 5/5] Revert: "net:... Paolo Abeni
- Re: [PATCH net-next 5/5] Revert: "net: sch... kbuild test robot
- Re: [PATCH net-next 5/5] Revert: "net: sch... kbuild test robot
- [PATCH net-next 4/5] net: sched: when clearing NOLO... Paolo Abeni