On 4/1/19 9:09 AM, Daniel Borkmann wrote: > On 03/29/2019 08:10 PM, Alexei Starovoitov wrote: >> On Thu, Mar 28, 2019 at 6:02 PM Andrey Ignatov <r...@fb.com> wrote: >>> >>> The patch set adds support for stack access with variable offset from >>> helpers. >>> >>> Patch 1 is the main patch in the set and provides more details. >>> Patch 2 adds selftests for new functionality. >> >> Applied. Thanks > > Hmm, I think this series needs more work unfortunately. The selftests are only > checking root-only programs, which is way to little. For !root we do the > spectre > masking for map and stack ALU, and that hasn't been adapted here, so it will > generate a wrong masking for runtime since it doesn't take variable part into > account. Andrey, please take a look.
right. may be we should allow this for root only then?
