On Thu, 28 Mar 2019 22:12:42 +0100, Jiri Pirko wrote: > From: Jiri Pirko <j...@mellanox.com> > > To provide visibility of the ports, this patchset exposes switch ID > for devlink ports, which are part of a switch. The rest of the ports > if any (in case of sr-iov for example) do not set switch ID.
I don't feel good about this patch set. There is no visibility provided here. Should the port flavour should be a sufficient indication of whether netdev associated with that port can be switched to or not? CPU, DSA, and Host flavours can't be switched to. And the switchid can be an attribute of the devlink instance, if we want to expose it via devlink.
