Thu, Mar 21, 2019 at 02:41:01PM CET, and...@lunn.ch wrote:
>On Thu, Mar 21, 2019 at 02:20:17PM +0100, Jiri Pirko wrote:
>> + switch (dp->type) {
>> + case DSA_PORT_TYPE_CPU:
>> + flavour = DEVLINK_PORT_FLAVOUR_CPU;
>> + break;
>> + case DSA_PORT_TYPE_DSA:
>> + flavour = DEVLINK_PORT_FLAVOUR_DSA;
>> + break;
>> + case DSA_PORT_TYPE_USER: /* fall-through */
>> + default:
>> + flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
>> + break;
>> + }
>> +
>> + /* dp->index is used now as port_number. However
>> + * CPU ports should have separate numbering
>> + * independent from front panel port numbers.
>> + */
>
>Hi Jiri
>
>Given the way you have rearranged this code, i think the text above
>should now be:
>
>However CPU ports and DSA ports should have separate numbering.
You are right. Will fix in v2.
>
> Andrew
