Hi Rosen,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on v5.0 next-20190306]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Rosen-Penev/net-aquantia-Switch-alloc_etherdev-to-devm-variant/20190309-181154
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/aquantia/atlantic/aq_main.c:33:16: sparse: error: 
>> undefined identifier 'devm_alloc_etherdev_mq'

vim +/devm_alloc_etherdev_mq +33 
drivers/net/ethernet/aquantia/atlantic/aq_main.c

    27  
    28  struct net_device *aq_ndev_alloc(void)
    29  {
    30          struct net_device *ndev = NULL;
    31          struct aq_nic_s *aq_nic = NULL;
    32  
  > 33          ndev = devm_alloc_etherdev_mq(aq_nic->ndev, sizeof(struct 
aq_nic_s),
    34                                        AQ_CFG_VECS_MAX);
    35          if (!ndev)
    36                  return NULL;
    37  
    38          aq_nic = netdev_priv(ndev);
    39          aq_nic->ndev = ndev;
    40          ndev->netdev_ops = &aq_ndev_ops;
    41          ndev->ethtool_ops = &aq_ethtool_ops;
    42  
    43          return ndev;
    44  }
    45  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to