On Tue, 02 Jan 2007 14:08:21 +0100, Jan Kiszka wrote: > What I (think to) understand is that a low-level drivers call > ieee80211_stop_queue() if they run out of buffers. That flips a > per-queue bit (IEEE80211_LINK_STATE_XOFF), prevents that any further > frame is passed to the low-level TX routine,
Correct. > and can cause that up to > *one* packet per queue is stored in > ieee80211_local::pending_packets[queue]. This is needed due to fragmented frames. After resume, passing of fragments to the driver has to continue where it was stopped. Returning the half-sent fragmented frame to the 802.11 qdisc wasn't possible until recently (I think the conversion of master interface to native 802.11 type could allow that now - but it's probably not worth the effort). > But it looks to me like nothing > prevents ieee80211_tx() being invoked even in case that there is already > some stuff in that single-packet storage. The 802.11 qdisc (see wme_qdiscop_dequeue) takes care of that. > That in turn triggers WARN_ONs in ieee80211_tx() under high load for me > (with rt2500usb). And it should also cause orphaned skbs because the > storage is overwritten in that case. Either I'm blind or something is > fishy... You are most likely hitting some bug. Could you post more information please? Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
