On 03/06/2019 08:35 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn <will...@google.com>
>
> BPF can adjust gso only for tcp bytestreams. Fail on other gso types.
>
> But only on gso packets. It does not touch this field if !gso_size.
>
> Fixes: b90efd225874 ("bpf: only adjust gso_size on bytestream protocols")
> Signed-off-by: Willem de Bruijn <will...@google.com>
Good catch, applied, thanks!
> Stupid bug on my part. Found only when adding tests for the feature.
> Will try to upstream those once bpf-next opens.
>
> On a related note, also working on a flag BPF_F_ADJ_ROOM_FIXED_GSO
> that will allow reenabling this field for UDP (and possibly avoiding
> the expensive skb_cow for the TCP common case).
Nice, looking forward!
