On Mon, Mar 04, 2019 at 08:19:14PM -0500, Su Yanjun wrote: > For rcu protected pointers, we'd better add '__rcu' for them. > > Once added '__rcu' tag for rcu protected pointer, the sparse tool reports > warnings. > > net/xfrm/xfrm_user.c:1198:39: sparse: expected struct sock *sk > net/xfrm/xfrm_user.c:1198:39: sparse: got struct sock [noderef] <asn:4> > *nlsk > [...] > > So introduce a new wrapper function of nlmsg_unicast to handle type > conversions. > > No functional change.
While that was true for v1 of that patch, it is not true for this version. This fixes a direct access of a rcu protected socket. So please add a proper 'Fixes' tag.
