From: Florian Fainelli <f.faine...@gmail.com>
Date: Fri, 1 Mar 2019 10:37:25 -0800
> We were skipping the prepare phase which causes some problems with at
> least a couple of drivers:
>
> - mv88e6xxx chooses to skip programming VID = 0 with -EOPNOTSUPP in
> the prepare phase, but we would still try to force this VID since we
> would only call the commit phase and so we would get the driver to
> return -EINVAL instead
>
> - qca8k does not currently have a port_vlan_add() callback implemented,
> yet we would try to call that unconditionally leading to a NPD
>
> Fix both issues by conforming to the current model doing a
> prepare/commit phase, this makes us consistent throughout the code and
> assumptions.
>
> Reported-by: Heiner Kallweit <hkallwe...@gmail.com>
> Reported-by: Michal Vokáč <michal.vo...@ysoft.com>
> Fixes: 061f6a505ac3 ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid
> implementation")
> Signed-off-by: Florian Fainelli <f.faine...@gmail.com>
Applied, thanks Florian.
