On 3/1/19 9:52 AM, Florian Fainelli wrote: [snip]
>> Tested-by: Michal Vokáč <michal.vo...@ysoft.com> >> >> I am not sure what was the original problem as I could not find the >> thread where Heiner reported the issue but with the latest version >> next-20190228 I get this error with QCA8334 switch: > > Thanks Michal. There is still a lingering issue though, because we > currently skip the prepare phase (we don't have a switchdev_trans > structure that would make sense here), we are not checking that the > underlying switch device driver does actually support > port_vlan_add/port_vlan_del, and qca8k currently does not. I will submit > a v2 patch that also takes care of that. David, please discard this version, I will submit a version that properly emulates the prepare/commit phase such that no assumptions are broken, this will take care of both issues at once. Thanks! -- Florian
