From: Michael Chan <[email protected]> Date: Tue, 26 Feb 2019 10:22:42 -0800
> On Tue, Feb 26, 2019 at 9:13 AM David Miller <[email protected]> wrote: >> >> From: Michael Chan <[email protected]> >> Date: Tue, 26 Feb 2019 05:56:41 -0500 >> >> > There have been reports of oversize UDP packets being sent to the >> > driver to be transmitted, causing error conditions. The issue is >> > likely caused by the dst of the SKB switching between 'lo' with >> > 64K MTU and the hardware device with a smaller MTU. Patches are >> > being proposed by Mahesh Bandewar <[email protected]> to fix the >> > issue. >> > >> > Separately, we should add a length check in validate_xmit_skb() >> > to drop these oversize packets before they reach the driver. >> > This patch only validates non-TSO packets. Complete validation >> > of segmented TSO packet size will probably be too slow. >> > >> > Signed-off-by: Michael Chan <[email protected]> >> >> Anything which changes the dst of an SKB really is responsible for >> fixing up whatever became "incompatible" in the new path. >> >> So like Eric I want to see this out of the fast path. > > Ok. In the meantime, will you take a 2-line bnxt_en patch that will > prevent this issue in kernel 5.0? Sure, but we will have to remember to remove it when it is no longer necessary...
