On 02/26/2019 06:33 PM, Martin Lau wrote: > On Tue, Feb 26, 2019 at 10:15:37PM +0800, zerons wrote: >> [ Upstream commit c91951f15978f1a0c6b65f063d30f7ea7bc6fb42 ] >> >> In bpf/syscall.c, bpf_map_get_fd_by_id() use bpf_map_inc_not_zero() to >> increase >> the refcount, both map->refcnt and map->usercnt. Then, if bpf_map_new_fd() >> fails, >> should handle map->usercnt too. > Good catch! Thanks for the fix.
+1 > Fixes: bd5f5f4ecb78 ("bpf: Add BPF_MAP_GET_FD_BY_ID") > Acked-by: Martin KaFai Lau <ka...@fb.com> Applied, thanks!