-----Original Message----- From: Andrew Morton <[EMAIL PROTECTED]> Date: Sunday, Dec 24, 2006 7:25 pm Subject: Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]
On Mon, 25 Dec 2006 05:21:24 +0800 >"Adam J. Richter" <[EMAIL PROTECTED]> wrote: > >> Under 2.6.20-rc1 and 2.6.20-rc2, I get the following complaint > for several network programs running on my system: > > [ 156.381868] BUG: sleeping function called from invalid context at > net/core/sock.c:1523 > [ 156.381876] in_atomic():1, irqs_disabled():0 > [ 156.381881] no locks held by kio_http/9693. > [ 156.381886] [<c01057a2>] show_trace_log_lvl+0x1a/0x2f > [ 156.381900] [<c0105dab>] show_trace+0x12/0x14 > [ 156.381908] [<c0105e48>] dump_stack+0x16/0x18 > [ 156.381917] [<c011e30f>] __might_sleep+0xe5/0xeb > [ 156.381926] [<c025942a>] lock_sock_nested+0x1d/0xc4 > [ 156.381937] [<c01cc570>] selinux_netlbl_inode_permission+0x5a/0x8e > [ 156.381946] [<c01c2505>] selinux_file_permission+0x96/0x9b > [ 156.381954] [<c0175a0a>] vfs_write+0x8d/0x167 > [ 156.381962] [<c017605a>] sys_write+0x3f/0x63 > [ 156.381971] [<c01040c0>] syscall_call+0x7/0xb > [ 156.381980] ======================= > > >There's a glaring bug in selinux_netlbl_inode_permission() - taking >lock_sock() inside rcu_read_lock(). > >I would again draw attention to Documentation/SubmitChecklist. In >particular please always always always enable all kernel debugging options >when developing and testing new kernel code. And everything else in that >file, too. > I apologize for the mistake - I'm still trying to get a firm grasp on some of the finer points of Linux kernel development and I obviously missed something here. Unfortunately, due to the holiday I won't be able to write/test/submit a patch until after the first of the year but I promise to do so as soon as I am able. . paul moore . linux security @ hp - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
