2019-02-25, 15:47:00 +0800, Hangbin Liu wrote: > @@ -14,6 +15,7 @@ int rtm_getroute_parse_ip_proto(struct nlattr *attr, u8 > *ip_proto, > case IPPROTO_TCP: > case IPPROTO_UDP: > case IPPROTO_ICMP: > + case IPPROTO_ICMPV6:
Is IPPROTO_ICMPV6 supposed to be valid in the IPv4 code path calling this function? inet_rtm_getroute_build_skb() doesn't seem to handle it. Likewise, userspace could pass IPPROTO_ICMP from the IPv6 caller. Also, should that be guarded by #if IS_ENABLED(CONFIG_IPV6) ? > return 0; > default: > NL_SET_ERR_MSG(extack, "Unsupported ip proto"); > -- > 2.19.2 > -- Sabrina
