On Sat, 2019-02-23 at 13:21 -0800, David Miller wrote: > From: Yafang Shao <laoar.s...@gmail.com> > Date: Sun, 17 Feb 2019 22:26:32 +0800 > > > SOCK_DEBUG() is a old facility for debugging. > > If the user want to use it for debugging, the user must modify the > > application first, that doesn't seem like a good way. > > Now we have more powerful facilities, i.e. bpf or tracepoint, for this kind > > of debugging purpose. > > So we'd better disable it by default. > > The reason why I don't remove it comepletely is that someone may still > > would like to use it for debugging. > > > > Signed-off-by: Yafang Shao <laoar.s...@gmail.com> > > Suggested-by: Joe Perches <j...@perches.com> > > Sorry, I'm not applying this. > > You are forcing everyone who wants to use this to add a curstom local > source code change into their build.
That may not actually be a bad thing. It could become a CONFIG bit too. I'm not sure how often it's actually used. Outside of the likely to be removed tcp uses, it's currently used only in appletalk/ddp, x25, and the 1 use in dccp. All of the existing uses could likely be removed without much notice by anyone.
