Hi! This is a follow up to the series which added device flash updates via devlink. I went with the approach of adding a new NDO in the end. It seems to end up looking cleaner (the port favour patches are coming regardless ;)).
First patch removes the option to build devlink as a module. Users can still decide to not build it, but the module option ends up not being worth the maintenance cost. Second patch fixes a potential issue with ethtool code, which will become even more problematic as the NDO introduced by the third patch does not hold RTNL. The new NDO allows the core to get the devlink instance based on a netdev pointer. Next the NDO is implemented in the NFP, and ethtool flashing ops removed. v2: add netdev_to_devlink() in patch 3. Jakub Kicinski (5): net: devlink: turn devlink into a built-in ethtool: hold a reference to the netdevice around devlink compat devlink: create a special NDO for getting the devlink instance nfp: add .ndo_get_devlink nfp: remove ethtool flashing fallback drivers/infiniband/hw/bnxt_re/Kconfig | 1 - drivers/infiniband/hw/mlx4/Kconfig | 1 - drivers/net/Kconfig | 1 - drivers/net/ethernet/broadcom/Kconfig | 1 - drivers/net/ethernet/cavium/Kconfig | 1 - drivers/net/ethernet/mellanox/mlx4/Kconfig | 1 - .../net/ethernet/mellanox/mlx5/core/Kconfig | 1 - drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 - drivers/net/ethernet/netronome/Kconfig | 1 - drivers/net/ethernet/netronome/nfp/nfp_app.h | 2 + .../net/ethernet/netronome/nfp/nfp_devlink.c | 11 +++ .../ethernet/netronome/nfp/nfp_net_common.c | 1 + .../ethernet/netronome/nfp/nfp_net_ethtool.c | 24 ------ .../net/ethernet/netronome/nfp/nfp_net_repr.c | 1 + include/linux/netdevice.h | 6 ++ include/net/devlink.h | 19 +++-- net/Kconfig | 11 +-- net/core/devlink.c | 73 +++++-------------- net/core/ethtool.c | 11 ++- net/dsa/Kconfig | 2 +- 20 files changed, 61 insertions(+), 109 deletions(-) -- 2.19.2
