On Mon, Feb 11, 2019 at 12:56 AM Vlad Buslov <vla...@mellanox.com> wrote: > > Register netlink protocol handlers for message types RTM_NEWTFILTER, > RTM_DELTFILTER, RTM_GETTFILTER as unlocked. Set rtnl_held variable that > tracks rtnl mutex state to be false by default. > > Introduce tcf_proto_is_unlocked() helper that is used to check > tcf_proto_ops->flag to determine if ops can be called without taking rtnl > lock. Manually lookup Qdisc, class and block in rule update handlers. > Verify that both Qdisc ops and proto ops are unlocked before using any of > their callbacks, and obtain rtnl lock otherwise.
So if you end goal is to completely get rid of RTNL from tc filter and action control path, why this change is needed? I was expecting you to break down the RTNL lock down to each block/filter chain, which should be done in this patchset. So again, why do we still need RTNL for some cases? Please state the reasoning in your changelog, rather than just describing what your code does. Thanks.
