On 15.02.2019 19:58, Willem de Bruijn wrote: > On Fri, Feb 15, 2019 at 11:51 AM Alexey Kodanev > <alexey.koda...@oracle.com> wrote: >> >> For unsupported protocols, setsockopt() with SO_ZEROCOPY >> option sets errno to ENOTSUPP(524). But this number is >> not defined anywhere in the include/uapi/ headers. >> >> To make sure userspace sees the known number, replace >> ENOTSUPP(524) with EOPNOTSUPP(95). >> >> Fixes: 76851d1212c1 ("sock: add SOCK_ZEROCOPY sockopt") >> Signed-off-by: Alexey Kodanev <alexey.koda...@oracle.com> >> Reported-by: Petr Vorel <pvo...@suse.cz> > > This code has been there since 4.14. I think it's too late to change > system call behavior. >
'ENOTSUPP' define is solely for an internal usage, it may be replaced with another one or the number associated with it may be changed one day, implicitly changing the behavior of setsockopt().