On 16.02.2019 17:00, Andrew Lunn wrote: > On Fri, Feb 15, 2019 at 09:57:49PM +0100, Heiner Kallweit wrote: >> Similar to the existing helpers for the Clause 22 registers add helpers >> to deal with converting Clause 45 advertisement registers to / from >> link mode bitmaps. >> >> Note that these helpers are defined in linux/mdio.h, not like the >> Clause 22 helpers in linux/mii.h. Reason is that the Clause 45 register >> constants are defined in uapi/linux/mdio.h. And uapi/linux/mdio.h >> includes linux/mii.h before defining the C45 register constants. > > Hi Heiner > > You add three helpers, but the followup patch only uses one of them. > Maybe you should wait until you have real uses of the other two? > Or just add the one helper. > Ah, right. I created all helpers but at least one user isn't ready yet. I'll resend the series with just the helper being used now.
> Andrew > Heiner
