On Fri, Feb 15, 2019 at 04:32:29PM +0100, Antoine Tenart wrote: > This patch makes the link interrupt handler to avoid calling > phylink_mac_change when there are no event.
The reasoning being? > > Signed-off-by: Antoine Tenart <antoine.ten...@bootlin.com> > --- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index b42189260670..857b079f1a29 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -2477,14 +2477,14 @@ static irqreturn_t mvpp2_link_status_isr(int irq, > void *dev_id) > } > } > > + if (!netif_running(dev) || !event) > + goto handled; > + > if (port->phylink) { > phylink_mac_change(port->phylink, link); > goto handled; > } > > - if (!netif_running(dev) || !event) > - goto handled; > - > if (link) { > mvpp2_interrupts_enable(port); > > -- > 2.20.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up