On Wed, Feb 13, 2019 at 11:04 PM Stephen Hemminger
<step...@networkplumber.org> wrote:
>
> On Wed, 13 Feb 2019 15:40:30 +0100
> Matteo Croce <mcr...@redhat.com> wrote:
>
> > When attaching an eBPF program to a device, ip link can force the XDP mode
> > by using the xdp{generic,drv,offload} keyword instead of just 'xdp'.
> > Document this behaviour also in the help output.
> >
> > Signed-off-by: Matteo Croce <mcr...@redhat.com>
> > Fixes: 14683814 ("bpf: add xdpdrv for requesting XDP driver mode")
> > Fixes: 1b5e8094 ("bpf: allow requesting XDP HW offload")
>
> Applied, thanks.
> The man page already has this as well.
>Yes, I found it just after I made the patch. However, it could be nice to have the generic "xdp" and a command like "type" or "mode" to specify the XDP mode, eg. ip link set dev eth0 xdp mode [ auto | generic | drv | offload ] I was trying to add it, but unfortunately it seems that the arguments aren't parsed in a loop, and are required to be in the exact order. Would this change make sense? Regards, -- Matteo Croce per aspera ad upstream
