On Wed, Feb 13, 2019 at 10:49 AM Alexei Starovoitov <alexei.starovoi...@gmail.com> wrote: > > On Tue, Feb 12, 2019 at 6:15 PM Eric Dumazet <eduma...@google.com> wrote: > > > > Do not add more debugging stuff unless you can demonstrate > > they actually allowed you to find a real bug and that you sent a > > public fix for it. > > > > Just adding "cool stuff" in TCP stack does not please me, it is only > > more complexity for unproven gain. > > I agree. > I don't see why this debugging of 'abnormal TCP' cannot be done > with kprobes and tracepoints.
kprobe is not suitable, because we have to use the line number, that's a trouble cross all kernel versions. Regarding tracepoints, I don't think it is a good idea to introduce more and more tcp tracepoints and make them crowed as well. > Instrumenting every tcp counter increment is overkill.
