> > +static void ksz9477_freeze_mib(struct ksz_device *dev, int port, bool
> freeze)
> > +{
> > + struct ksz_port *p = &dev->ports[port];
> > + u32 val = freeze ? MIB_COUNTER_FLUSH_FREEZE : 0;
>
> Reverse Christmas tree.
There was a checkpatch.pl patch in 2016 that tried to check this, but it was
never accepted?
> > + /* read only dropped counters when link is not up */
> > + if (p->link_just_down)
> > + p->link_just_down = 0;
> > + else if (!p->phydev.link)
> > + mib->cnt_ptr = dev->reg_mib_cnt;
>
> This link_just_down stuff is not clear at all. Why can the drop
> counters not be read when the link is up?
All of the MIB counters, except some that may be marked by driver, do not get
updated when the link is down, so it is a waste of time to read them.
My intention is the driver eventually reads the MIB counters at least every
second or faster so that the ethtool API called to show MIB counters gets them
from memory rather than starting a read operation. For now that API is called
from user space with the ethtool utility, so it may not be called too often and
too fast. But theoretically that API can be called from a program continually.
For simple switches that do not need to do anything special the MIB read
operation does not cause any issue except CPU load, for more complicate
switches that need to do some background operations too many read operation can
affect some critical functions.
