On Tue, Feb 12, 2019 at 11:42:31AM +0000, Kiyanovski, Arthur wrote:
> Hi Moritz,
>
> > -----Original Message-----
> > From: Moritz Fischer <moritz.fisc...@ettus.com>
> > Subject: Re: [PATCH V1 net 2/2] net: ena: update driver version from 2.0.2
> > to
> > 2.0.3
> >
> > Hi Arthur,
> >
> > On Mon, Feb 11, 2019 at 9:19 AM <akiy...@amazon.com> wrote:
> > >
> > > From: Arthur Kiyanovski <akiy...@amazon.com>
> > >
> > > Update driver version due to bug fix.
> >
> > Wouldn't you want to do this atomically with the actual fix in one commit?
> >
> > Thanks,
> > Moritz
>
> Thanks for the feedback.
> I don't want to add the version to the fix.
> Version 2.0.3 includes all of its content that came before this fix,
> including features.
> Fixes are cherry-picked to older driver versions automatically using the
> "Fixes:" directive.
> If I add the version change to the fix, older driver versions that get this
> fix will become version 2.0.3, which is incorrect feature-wise.
Hi Arthur
I think this points out how useless the version string it, and why
many drivers don't use it.
Andrew
