David Young wrote:
> On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote:
>> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote:
>>> --- a/include/net/ieee80211_radiotap.h
>>> +++ b/include/net/ieee80211_radiotap.h
>>> @@ -168,6 +168,23 @@ struct ieee80211_radiotap_header {
>>> * Unitless indication of the Rx/Tx antenna for this packet.
>>> * The first antenna is antenna 0.
>>> *
>>> + * IEEE80211_RADIOTAP_RX_FLAGS u_int16_t bitmap
>>> + *
>>> + * Properties of received frames. See flags defined below.
>>> + *
>>> + * IEEE80211_RADIOTAP_TX_FLAGS u_int16_t bitmap
>>> + *
>>> + * Properties of transmitted frames. See flags defined below.
>>> + *
>>> + * IEEE80211_RADIOTAP_RTS_RETRIES u_int8_t data
>>> + *
>>> + * Number of rts retries a transmitted frame used.
>>> + *
>>> + * IEEE80211_RADIOTAP_DATA_RETRIES u_int8_t data
>>> + *
>>> + * Number of unicast retries a transmitted frame used.
>>> + *
>>> + *
>>> * IEEE80211_RADIOTAP_FCS u32 data
>>> *
>>> * FCS from frame in network byte order.
>>> @@ -187,7 +204,11 @@ enum ieee80211_radiotap_type {
>>> IEEE80211_RADIOTAP_ANTENNA = 11,
>>> IEEE80211_RADIOTAP_DB_ANTSIGNAL = 12,
>>> IEEE80211_RADIOTAP_DB_ANTNOISE = 13,
>>> - IEEE80211_RADIOTAP_EXT = 31,
>>> + IEEE80211_RADIOTAP_RX_FLAGS = 14,
>>> + IEEE80211_RADIOTAP_TX_FLAGS = 15,
>>> + IEEE80211_RADIOTAP_RTS_RETRIES = 16,
>>> + IEEE80211_RADIOTAP_DATA_RETRIES = 17,
>>> + IEEE80211_RADIOTAP_EXT = 31
>>> };
>>>
>>> /* Channel flags. */
>> Did you send this part to netbsd also? We really don't want to fork
>> radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's
>> all rolled together for convenience.
>
> No, especially since NetBSD is where I keep the authoritative definitions.
>
> How have you defined RX_FLAGS and TX_FLAGS?
>
> BTW, IEEE80211_RADIOTAP_FCS (above) never made it into radiotap. No bit
> is reserved.
Tell that to everyone that implements it.
Sam
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
