On Wed, Feb 6, 2019 at 12:17 PM Eric Dumazet <eduma...@google.com> wrote: > > On Wed, Feb 6, 2019 at 12:15 PM Saeed Mahameed > <sae...@dev.mellanox.co.il> wrote: > > > > Ok, just verified, csum complete (cqe->checksum) is provided and valid > > for non-TCP/UDP ip packets, (on specific ConnectX3 HWs) > > e.g. ICMP packets or IP fragments go through csum complete, that > > being said, looking at the code before my patch. > > when cqe->checksum complete is not valid a IP non-TCP/UDP packet will > > report csum NONE, which means my > > TODO comment is valid even without my patch :). > > > > We can remove the TODO, although i am fine with it if it kept there, > > since it is valid, > > but we must add a future optimization task (to tariq's backlog ;)) for > > IP non-TCP/UDP traffic to check for > > csum unnecessary when csum complete is not an option. > > > > > > Thanks for double checking. > You might add more details in the changelog for future generations ;)
Great, I will do that, we will post V2, Thank you Eric.
