Re: [PATCH iproute2-next v2] devlink: add info subcommand

[Jiri Pirko]

Mon, Feb 04, 2019 at 01:54:56AM CET, jakub.kicin...@netronome.com wrote:
>Add support for reading the device serial number, driver name
>and various versions.  Example:
>
>$ devlink dev info pci/0000:05:00.0
>pci/0000:05:00.0:
>  driver nfp
>  serial_number 16240145
>  versions:
>    fixed:
>      board.id AMDA0099-0001
>      board.rev 07
>      board.vendor SMA
>      board.model carbon
>    running:
>      fw.mgmt: 010156.010156.010156

Sometimes you have "x: y" and sometimes you have "x y". Please be
consistent.

Please also include json output here.

Thanks!

>      fw.cpld: 0x44
>      fw.app: sriov-2.1.16
>    stored:
>      fw.mgmt: 010158.010158.010158
>      fw.cpld: 0x44
>      fw.app: sriov-2.1.20
>
>v2 (Jiri):
> - remove filtering;
> - add example in the commit message.
>RFCv2:
> - make info subcommand of dev.
>

[...]