Hi Dave,
On Sun, 03 Feb 2019 20:26:06 -0800 (PST) David Miller <da...@davemloft.net>
wrote:
>
> Thanks, I just pushed the following:
>
> ====================
> [PATCH] net: Fix fall through warning in y2038 tstamp changes.
>
> net/core/sock.c: In function 'sock_setsockopt':
> net/core/sock.c:914:3: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> sock_set_flag(sk, SOCK_TSTAMP_NEW);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/core/sock.c:915:2: note: here
> case SO_TIMESTAMPING_OLD:
> ^~~~
>
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Reported-by: Stephen Rothwell <s...@canb.auug.org.au>
> Signed-off-by: David S. Miller <da...@davemloft.net>
> ---
> net/core/sock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/sock.c b/net/core/sock.c
> index a8904ae40713..71ded4d8025c 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -912,6 +912,7 @@ int sock_setsockopt(struct socket *sock, int level, int
> optname,
>
> case SO_TIMESTAMPING_NEW:
> sock_set_flag(sk, SOCK_TSTAMP_NEW);
> + /* fall through */
> case SO_TIMESTAMPING_OLD:
> if (val & ~SOF_TIMESTAMPING_MASK) {
> ret = -EINVAL;Looks good, thanks. -- Cheers, Stephen Rothwell
pgpoc2r5uSDDc.pgp
Description: OpenPGP digital signature
