It's too much effort to make the current r8169 compile under an older kernel. But thanks anyway for trying!
Heiner On 01.02.2019 18:19, Marc Haber wrote: > On Fri, Feb 01, 2019 at 07:49:09AM +0100, Heiner Kallweit wrote: >> Great, thanks. This patch has been applied and is part of latest linux-next >> kernel already: >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/?h=next-20190201 >> Would be much appreciated if you could build and test this kernel version. > > I regret that I have not been able to get this through the compiler. > When I clone the linux-next repo and try to build with deb-pkg, some > process chokes on the weird version number of the linux-next kernel, and > transplanting the r8169.c from linux-next on to 4.20.6, compile aborts: > > In file included from drivers/net/ethernet/realtek/r8169.c:13: > ./include/linux/pci.h:830:12: error: ‘PCI_VENDOR_ID_USR’ undeclared here (not > in a function); did you mean ‘PCI_VENDOR_ID_UMC’? > .vendor = PCI_VENDOR_ID_##vend, .device = (dev), \ > ^~~~~~~~~~~~~~ > drivers/net/ethernet/realtek/r8169.c:222:4: note: in expansion of macro > ‘PCI_VDEVICE’ > { PCI_VDEVICE(USR, 0x0116), RTL_CFG_0 }, > ^~~~~~~~~~~ > drivers/net/ethernet/realtek/r8169.c: In function ‘rtl8169_start_xmit’: > drivers/net/ethernet/realtek/r8169.c:6261:6: error: implicit declaration of > function ‘__netdev_sent_queue’; did you mean ‘netdev_sent_queue’? > [-Werror=implicit-function-declaration] > if (__netdev_sent_queue(dev, skb->len, skb->xmit_more)) > ^~~~~~~~~~~~~~~~~~~ > netdev_sent_queue > drivers/net/ethernet/realtek/r8169.c: In function ‘r8169_phy_connect’: > drivers/net/ethernet/realtek/r8169.c:6653:22: warning: passing argument 1 of > ‘linkmode_copy’ makes pointer from integer without a cast [-Wint-conversion] > linkmode_copy(phydev->advertising, phydev->supported); > ~~~~~~^~~~~~~~~~~~~ > In file included from ./include/linux/phy.h:22, > from drivers/net/ethernet/realtek/r8169.c:19: > ./include/linux/linkmode.h:13:49: note: expected ‘long unsigned int *’ but > argument is of type ‘u32’ {aka ‘unsigned int’} > static inline void linkmode_copy(unsigned long *dst, const unsigned long > *src) > ~~~~~~~~~~~~~~~^~~ > drivers/net/ethernet/realtek/r8169.c:6653:43: warning: passing argument 2 of > ‘linkmode_copy’ makes pointer from integer without a cast [-Wint-conversion] > linkmode_copy(phydev->advertising, phydev->supported); > ~~~~~~^~~~~~~~~~~ > In file included from ./include/linux/phy.h:22, > from drivers/net/ethernet/realtek/r8169.c:19: > ./include/linux/linkmode.h:13:75: note: expected ‘const long unsigned int *’ > but argument is of type ‘u32’ {aka ‘unsigned int’} > static inline void linkmode_copy(unsigned long *dst, const unsigned long > *src) > ~~~~~~~~~~~~~~~~~~~~~^~~ > cc1: some warnings being treated as errors > make[4]: *** [scripts/Makefile.build:297: > drivers/net/ethernet/realtek/r8169.o] Error 1 > > Will it help if I transplant more files from linux-next to 4.20.6? > > Greetings > Marc >
